This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] fix py-finish-breakpoint.exp with always-async
- From: Yao Qi <yao at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 30 Jul 2013 08:35:47 +0800
- Subject: Re: [PATCH 7/8] fix py-finish-breakpoint.exp with always-async
- References: <1375116324-32092-1-git-send-email-tromey at redhat dot com> <1375116324-32092-8-git-send-email-tromey at redhat dot com>
On 07/30/2013 12:45 AM, Tom Tromey wrote:
However, the code did not follow this comment -- it didn't check to
see if the command started the target.
This patch fixes the problem by noting whether the target was
executing in sync_execution mode before running the command, and then
augmenting the condition to test this as well.
The rationale looks right to me.
Built and regtested on x86-64 Fedora 18.
* top.c (execute_command): Only dispatch events if command
started target.
I opened PR 14135 for an internal error we saw in
gdb.python/py-finish-breakpoint.exp when async is on. If it is the
error this patch is to fix, please mention this patch fixes PR 14135 in
ChangeLog.
http://sourceware.org/bugzilla/show_bug.cgi?id=14135
I also posted a patch for this PR, but it doesn't apply to current trunk.
--
Yao (éå)