This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] dwarf2read.c: fix computing list of included symtabs
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 29 Jul 2013 13:10:16 -0600
- Subject: Re: [RFA] dwarf2read.c: fix computing list of included symtabs
- References: <yjt2li6au2eq dot fsf at ruffy dot mtv dot corp dot google dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> My workaround for http://sourceware.org/bugzilla/show_bug.cgi?id=15021
Doug> doesn't take into account the fact that TUs can share symtabs.
Doug> This results in duplicate copies of symtabs in symtab->includes.
Doug> Regression tested on amd64-linux with/without fission, and with dwz.
Doug> Ok to check in?
Doug> 2013-06-15 Doug Evans <dje@google.com>
Doug> * dwarf2read.c (recursively_compute_inclusions): Change type of
Doug> result parameter to VEC (symtab_ptr) **. New parameter all_type_symtabs.
Doug> Watch for duplicate symtabs coming from type units.
Doug> (compute_symtab_includes): Update call to recursively_compute_inclusions.
Doug> Build vector of included symtabs instead of per_cus.
Doug> * symtab.h (symtab_ptr): New typedef.
Doug> (DEF_VEC_P (symtab_ptr)): New VEC type.
Looks good to me.
Tom