This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Revised display-linkage-name
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Eager <eager at eagerm dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Mon, 29 Jul 2013 11:48:38 -0600
- Subject: Re: [PATCH] Revised display-linkage-name
- References: <519D086A dot 50105 at eagerm dot com> <51BF47DB dot 6070709 at eagerm dot com> <51DD891D dot 7090009 at eagerm dot com> <51DF3F97 dot 90805 at redhat dot com> <51E07263 dot 6080605 at eagerm dot com> <51E6E797 dot 30709 at eagerm dot com> <51ED705A dot 5000601 at redhat dot com> <51ED90E3 dot 30801 at eagerm dot com> <51EDAA3A dot 5090504 at redhat dot com> <51EFF8F8 dot 6050807 at eagerm dot com> <874nbhtb80 dot fsf at fleche dot redhat dot com> <51F2D975 dot 3060801 at eagerm dot com>
>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
Tom> FWIW there isn't much need to add new annotations. Annotations are
Tom> officially deprecated. It's fine by me if you want to leave this in for
Tom> some reason though.
Michael> I added the annotations at your request (4/19/13):
Tom>> I think for MI it is better to make this a real field.
Tom>> Also I wonder whether this should be emitted unconditionally if
Tom>> mi-like. Say:
Michael> Perhaps I misunderstood what you meant by "make this a real field".
Yeah, I'm sorry I wasn't clearer.
"annotations" refers to annotate.[ch] and the corresponding command-line
option. This is an old way to communicate gdb state changes to a GUI,
mainly Emacs.
By "a real field" I meant using ui_out_*.
Michael> + ui_out_text (uiout, linkname);
Tom> This is emitting the linkage name using ui_out_text. That is wrong for
Tom> MI.
It maybe wasn't clear but I was referring to the quoted line above when
I said this.
Michael> What should it be? ui_out_field_string()? Something else?
Yes, ui_out_field_string.
Tom