This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: don't call add_target for thread_db_ops
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Jul 2013 15:39:20 +0100
- Subject: Re: RFC: don't call add_target for thread_db_ops
- References: <1372783053-14925-1-git-send-email-tromey at redhat dot com> <51D3E4CB dot 3060801 at redhat dot com> <87ehamwwtq dot fsf at fleche dot redhat dot com>
On 07/25/2013 03:14 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
>>> * linux-thread-db.c (init_thread_db_ops): Call
>>> complete_target_initialization.
>>> (_initialize_thread_db): Don't call add_target.
>>> * target.c (complete_target_initialization): New function.
>>> (add_target_with_completer): Call it.
>>> * target.h (complete_target_initialization): Declare.
>
> Pedro> This is OK.
>
> Thanks. I'm checking it in now.
Thanks. Do you plan on doing the same to the remaining
thread_stratum targets? If not, I'll do it at some point.
I'd prefer not leaving the incomplete transition in
place; it's bound to confuse someone later on. I wouldn't
worry much if an affected target goes untested.
--
Pedro Alves