This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: [PATCH] fix Bug 11568 - delete thread-specific breakpoint on the thread exit


Thanks for reviewing the patch.

gdb


2013-07-24   Muhammad Waqas  <waqas.jamil47@gmail.com>

    * breakpoint.c (breakpoint_auto_delete): Remove breakpoint
    Remove thread related breakpoints if threads are exited.



one test case is given in my 1st post.

For Copyright assignment, I'm not having it yet, hopefully will got it soon.

On Tue, Jul 23, 2013 at 11:24 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Waqas Jamil <waqas.jamil47@gmail.com> writes:
>
>>> Now is it ok?
>>> 2013-07-22  Muhammad  Waqas  <waqas.jamil47@gmail.com>
>
>>>              * breakpoint.c (breakpoint_auto_delete): remove breakpoints
>>>              remove thread specified breakpoints
>
> The body of the entry should be indented with tabs.
> "remove" should have a capital "r" and there should be a "." at the end.
>
>>> --- mygdb/gdb-7.6/gdb/breakpoint.c      2013-07-23 08:30:56.231681932 +0500
>>> +++ /home/waqas/Downloads/gdb/gdb-7.6/gdb/breakpoint.c  2013-04-25
>
> Your patch is reversed.
>
> Also, this needs a test case.
>
> Finally, do you have a copyright assignment in place?
> If not, contact me off-list to get started.
>
> Tom



-- 

Regards :
           Muhammad Waqas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]