This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Revised display-linkage-name
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Michael Eager <eager at eagerm dot com>
- Cc: keiths at redhat dot com, gdb-patches at sourceware dot org, tromey at redhat dot com
- Date: Wed, 17 Jul 2013 22:14:40 +0300
- Subject: Re: [PATCH] Revised display-linkage-name
- References: <519D086A dot 50105 at eagerm dot com> <51BF47DB dot 6070709 at eagerm dot com> <51DD891D dot 7090009 at eagerm dot com> <51DF3F97 dot 90805 at redhat dot com> <51E07263 dot 6080605 at eagerm dot com> <51E6E797 dot 30709 at eagerm dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 17 Jul 2013 11:51:03 -0700
> From: Michael Eager <eager@eagerm.com>
> CC: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>,
> Tom Tromey <tromey@redhat.com>
>
> I believe I have addressed your comments, as well as Eli's previous
> notes about the docs. I didn't merge the tests cases into a single proc.
>
> BTW, "prepend" appears in several places in the docs. I replaced it this
> patch with prefix. If there is a concern that "prepend" sounds like jargon,
> then the other uses should be changed as well.
>
>
>
> gdb/
> 2013-07-17 Michael Eager <eager@eagercon.com>
>
> * NEWS: Announcement.
> * ada-lang.c: Update calls to find_frame_funname (pass NULL for linkname).
> * disasm.c: Likewise.
> * python/py-frame.c: Likewise.
> * annotate.c (annotate_linkage_name): New.
> * annotate.h (annotate_linkage_name): New decl.
> * breakpoint.c (print_breakpoint_location): Print linkage name.
> * defs.h (build_address_symbolic): Add linkname arg.
> * printcmd.c (print_address_symbolic): Print linkage name.
> (build_address_symbolic): Return linkage name.
> * annotate.c (annotate_linkage_name): New.
> * annotate.h (annotate_linkage_name): Declare.
> * stack.c (find_frame_funname): Return linkage name.
> (print_frame): Print linkage name.
> * stack.h (find_frame_funname): Update declaration.
> * top.c (display_linkage_name, display_linkage_name_len): New.
> (show_display_linkage_name, show_display_linkage_name_len): New cmds.
> * top.h (display_linkage_name, display_linkage_name_len): Declare.
>
> gdb/doc
> 2013-07-17 Michael Eager <eager@eagercon.com>
>
> * gdb.texinfo: Add description.
>
> gdb/testsuite
> 2013-07-17 Michael Eager <eager@eagercon.com>
>
> * gdb.cp/display-linkage-name.exp: New.
> * gdb.cp/display-linkage-name.cc: New.
>
Thanks, the documentation parts are OK.