This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] optimized out registers in mi
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 05 Jul 2013 15:03:26 +0100
- Subject: Re: [PATCH] optimized out registers in mi
- References: <51D6C9D8 dot 4000502 at broadcom dot com>
On 07/05/2013 02:27 PM, Andrew Burgess wrote:
> [1] I applied a patch yesterday that changed value_optimized_out,
> before I applied yesterdays patch the behaviour of -data-list-registers
> was a bit random, if the register value was lazy then you would get
> the "<optimized out>" result, if the value was not lazy then you got
> the error. Of the two behaviours I think returning the
> "<optimized out>" string is by far the most helpful so that's
> the behaviour we now get in all cases.
Agreed.
It'd be nice to handle partially optimized out registers
too, though I'm not sure gcc does something like that
currently. And that can be always handled later. This
is already a good step.
> gdb/ChangeLog
> - if (format == 'N')
> + /* Displaying optimized out values using anything other than the default
> + format will result in the value 0 being shown. */
Please make that s/will/would/. It's confusing as is; it made
me think that printing 0 was what the patch was meaning to do.
But, this looks hacky to me. Do we print 0 with the CLI as well?
If not, what's handling it that's missing in MI? Isn't this being
handled gracefully somewhere within val_print itself (I'd
think in val_print_scalar_formatted)?
--
Pedro Alves