This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/4] gdbserver, win32: fix some function typedefs
- From: Mircea Gherzan <mircea dot gherzan at intel dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: tromey at redhat dot com, jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Tue, 02 Jul 2013 14:58:44 +0200
- Subject: Re: [PATCH v2 3/4] gdbserver, win32: fix some function typedefs
- References: <1372699497-20043-1-git-send-email-mircea dot gherzan at intel dot com> <1372699497-20043-4-git-send-email-mircea dot gherzan at intel dot com> <51D1C0B1 dot 4020809 at redhat dot com>
On 01.07.2013 19:47, Pedro Alves wrote:
Not sure I'd call this a "fix", vs "our compiler works like
MSFT's here". Is gcc wrong in allowing the attribute outside
the parens?
WINAPI is __stdcall and thus "Microsoft specific". According to the
documentation [1], the modifier should be inside the parens.
Furthermore, this is consistent with the rest of the typedefs in the file.
On 07/01/2013 06:24 PM, Mircea Gherzan wrote:
2013-05-25 Mircea Gherzan <mircea.gherzan@intel.com>
gdbserver/
* win32-low.c (winapi_DebugActiveProcessStop): Move the WINAPI
attribute inside the parentheses.
(winapi_DebugSetProcessKillOnExit): Ditto.
(winapi_DebugBreakProcess): Ditto.
(winapi_GenerateConsoleCtrlEvent): Ditto.
OK.
Thanks, applied.
[1] http://msdn.microsoft.com/en-us/library/zxk0tw93.aspx
--
Mircea Gherzan
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052