This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h


On 27.06.2013 20:58, Pedro Alves wrote:
On 06/27/2013 12:32 PM, Pedro Alves wrote:
On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
2013-06-25  Mircea Gherzan  <mircea.gherzan@intel.com>

	* common/agent.c: Conditionally include unistd.h.

gdbserver/
	* hostio.c: Conditionally include unistd.h and define PATH_MAX
	if unistd.h is not available.
	* tracepoint.h: Conditionally include unistd.h.

Hmm, I've discussed this PATH_MAX issue before.
I think we should pull in the unistd and pathmax modules from
gnulib.  In hostio.c, we should cap the max path len to the max
of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer
size.  Let me post a series for that.

Posted at:

  http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html

Could you give it a try?

Work fine in my case, thanks! Please commit it so I can rebase my series on top of it.

Mircea

--

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]