This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/16] use the libiberty crc code
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 27 Jun 2013 14:03:40 -0600
- Subject: Re: [PATCH 01/16] use the libiberty crc code
- References: <1371835506-15691-1-git-send-email-tromey at redhat dot com> <1371835506-15691-2-git-send-email-tromey at redhat dot com> <51C87652 dot 60105 at redhat dot com>
Pedro> (gdbserver also has it's own copy in server.c (and for that one
Pedro> the return type does matter), but we don't use
Pedro> libiberty-the-kitchen-sink there... Oh well.)
If we used libiberty in gdbserver, we could replace this code. We'd
just have to hoist the inferior-memory-reading bit outside of the crc
function. This wouldn't be so bad; it might even be an improvement. I
don't plan to mess with this though.
Tom