This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 20 Jun 2013 10:28:44 -0700
- Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- References: <1369881867-11372-1-git-send-email-yao at codesourcery dot com> <1369881867-11372-3-git-send-email-yao at codesourcery dot com> <51B93F00 dot 5090002 at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1306171650220 dot 16287 at tp dot orcam dot me dot uk> <51C305F0 dot 90008 at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1306201624110 dot 16287 at tp dot orcam dot me dot uk>
> > If we put the prototypes into a single line, the length exceeds the
> > 74-character limit. This is the reason I moved parameter "set" to a new line.
> > Shall we keep them as what they are now?
>
> There's no 74-character limit for code, all you need is to stay
> within 79 columns. Did you apply the ChangeLog rule here?
Actually, the last time we discussed maximum code line length,
we settled on 70 characters.
Reference: http://www.sourceware.org/ml/gdb-patches/2011-01/msg00035.html
It's not consistent across files; for instance, it's 74 characters
in ChangeLogs. Those limits are kind of arbitrary, but I do find 79
characters to be slightly harder to read. Jan recently opened that
discussion again, and proposed 80 characters, but that did not stick.
I proposed to standardize on 74 instead, which is already the default
for some editors and the value used for ChangeLogs. But the discussion
then died. I'm not too surprised, since it's impossible to please
everybody, and controversial changes in the GDB porject have a tendency
of getting stuck.
--
Joel