This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 20 Jun 2013 16:25:59 +0100
- Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- References: <1369881867-11372-1-git-send-email-yao at codesourcery dot com> <1369881867-11372-3-git-send-email-yao at codesourcery dot com> <51B93F00 dot 5090002 at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1306171650220 dot 16287 at tp dot orcam dot me dot uk> <51C305F0 dot 90008 at codesourcery dot com>
On Thu, 20 Jun 2013, Yao Qi wrote:
> > > +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs);
> > > >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs,
> > > >+ int set);
> > > >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs,
> > > >+ int set);
> > The two prototypes above will fit in a single line each.
> >
>
> If we put the prototypes into a single line, the length exceeds the
> 74-character limit. This is the reason I moved parameter "set" to a new line.
> Shall we keep them as what they are now?
There's no 74-character limit for code, all you need is to stay within 79
columns. Did you apply the ChangeLog rule here?
Maciej