This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: another test case renaming fix
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 06 Jun 2013 13:00:00 -0600
- Subject: FYI: another test case renaming fix
I'm checking this in.
My test suite comparison showed another set of test cases whose names
depended on data from the inferior. These names could differ between
runs, leading to spurious comparison failures.
This renames various tests in dump.exp to make them not use inferior
addresses; and then fixes up one case where this change made two test
names conflict.
Tom
2013-06-06 Tom Tromey <tromey@redhat.com>
* gdb.base/dump.exp (capture_value): Don't put expression into
test name if arguments passed in.
Rename a couple more tests to make them unique.
Index: gdb.base/dump.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dump.exp,v
retrieving revision 1.28
diff -u -r1.28 dump.exp
--- gdb.base/dump.exp 1 Jan 2013 06:33:25 -0000 1.28
+++ gdb.base/dump.exp 6 Jun 2013 18:50:46 -0000
@@ -129,8 +129,9 @@
set output_string ""
if {[llength $args] > 0} {
- # Convert $args into a simple string.
- set test "[join $args]; capture $expression"
+ # Convert $args into a simple string and don't use EXPRESSION
+ # in the test name.
+ set test "[join $args]; capture"
} {
set test "capture $expression"
}
@@ -440,14 +441,14 @@
# Reload saved values one by one, and compare.
if { ![string compare $array_val \
- [capture_value "intarray" "file binfile"]] } then {
+ [capture_value "intarray" "file binfile; intarray"]] } then {
fail "start with intarray un-initialized"
} else {
pass "start with intarray un-initialized"
}
if { ![string compare $struct_val \
- [capture_value "intstruct" "file binfile"]] } then {
+ [capture_value "intstruct" "file binfile; intstruct"]] } then {
fail "start with intstruct un-initialized"
} else {
pass "start with intstruct un-initialized"