This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/7 take 2] API for inhibiting section map updates
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Thu, 30 May 2013 10:12:11 +0100
- Subject: Re: [RFA 2/7 take 2] API for inhibiting section map updates
- References: <20130516144340 dot GA2105 at blade dot nx> <20130516144813 dot GC2105 at blade dot nx> <87mwrpohnv dot fsf at fleche dot redhat dot com> <20130524074737 dot GB4602 at blade dot nx> <51A63846 dot 70905 at redhat dot com>
Pedro Alves wrote:
> On 05/24/2013 08:47 AM, Gary Benson wrote:
> > /* Update the table in exec_ops, used to read memory. */
> > ALL_OBJFILE_OSECTIONS (objfile, s)
> > @@ -1291,11 +1300,14 @@ static void
> > update_section_map (struct program_space *pspace,
> > struct obj_section ***pmap, int *pmap_size)
> > {
> > + struct objfile_pspace_info *pspace_info;
> > int alloc_size, map_size, i;
> > struct obj_section *s, **map;
> > struct objfile *objfile;
> >
> > - gdb_assert (get_objfile_pspace_data (pspace)->objfiles_changed_p != 0);
> > + pspace_info = get_objfile_pspace_data (current_program_space);
>
> Shouldn't this be 'pspace' instead of 'current_program_space'?
Good catch, thank you.
Gary
--
http://gbenson.net/