This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] msp430 instruction decoder


>  - in msp430_decode_opcode, are the multiple macro calls on the same line on=20
> purpose, or should those get fixed to be one per line ?  for example:
>   ID (dopc_to_id (dopc)); ASX (sreg, as, srxt_bits); ADX (dreg, a, dsxt_bits);=20
> ABW (al_bit, b);

On purpose.  The order of the macros is important, and they typically
correspond to bits in the bit pattern above it.  So the "common"
macros that pull out fields were kept on one line.

Plus, the source would be very white-heavy if you had one tiny macro
on each line ;-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]