This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: contribution checklist in the wiki
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 21 May 2013 09:25:52 +0400
- Subject: Re: contribution checklist in the wiki
- References: <51965CE3 dot 4020805 at redhat dot com> <20130520100618 dot GR4017 at adacore dot com> <519A3DCC dot 1020805 at redhat dot com>
> IMO, having CONTRIBUTE in the source tree is a bit questionable.
> E.g., a user might write a patch against 7.5, and send it to the list,
> using the guidelines from 7.5's CONTRIBUTE file. But, that file might
> well be outdated. The guidelines that really matter are the one's gdb
> developers follow at present, which may already be different from
> the one's in 7.5's CONTRIBUTE. I'd vote for migrating parts of the text
> from CONTRIBUTE under "Submitting Patches" and "Supplemental information
> for GDB" to the wiki. But we can leave CONTRIBUTE alone until the
> documents actually diverge.
Transitioning the info from CONTRIBUTE to point to the wiki would
be OK for me.
> I don't think we need to be super strict about these tags.
> [PATCH]/[patch]/nothing is the same to me, as is
> [RFC PATCH] vs [RFC][PATCH]. But I do think it's good to have
> simple guidelines, mostly for people who are newcomers to the community.
Agreed.
Glad to see you put the patch description in the commit log, BTW!
I started doing that a while ago too, internally first, really liking
it, and then externally as well.
--
Joel