This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 14/40] fix two buglets in breakpoint.c

From: Yao Qi <yao at codesourcery dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Mon, 13 May 2013 10:33:43 +0800
Subject: Re: [PATCH 14/40] fix two buglets in breakpoint.c
References: <cover dot 1368124285 dot git dot tromey at redhat dot com> <9950c2e4c9891c1b716d6c6d32107ddd7e97c5a5 dot 1368124285 dot git dot tromey at redhat dot com>

On 05/10/2013 02:51 AM, Tom Tromey wrote:

@@ -5814,7 +5814,10 @@ output_thread_groups (struct ui_out *uiout,
    /* For backward compatibility, don't display inferiors in CLI unless
       there are several.  Always display them for MI. */
    if (!is_mi && mi_only)
-    return;
+    {
+      do_cleanups (back_to);
+      return;
+    }


Tom,

A nit here, we may call 'make_cleanup_ui_out_list_begin_end' after thiscondition checking, so we don't need 'do_cleanups' here.


--
Yao (éå)

Follow-Ups:
- Re: [PATCH 14/40] fix two buglets in breakpoint.c
  - From: Tom Tromey
- Re: [PATCH 14/40] fix two buglets in breakpoint.c
  - From: Tom Tromey

References:
- [PATCH 00/40] add cleanup checker and fix cleanup bugs
  - From: Tom Tromey
- [PATCH 14/40] fix two buglets in breakpoint.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]