This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix the x87 FP register printout by “info float”.


On 04/18/2013 01:51 AM, Vladimir Kargov wrote:

> Another way to fix this would be to replace the type in the definition
> of variable "raw" from "char" to "gdb_char" which is currently defined
> as "unsigned char", 

You must have meant gdb_byte.  Actually, this (not checked in yet)
series does that:

 http://sourceware.org/ml/gdb-patches/2013-04/msg00327.html

Specifically this patch:

 http://sourceware.org/ml/gdb-patches/2013-04/msg00328.html

> but I couldn't find any signs in the code that
> this typedef wouldn't be changed in the future to something else.

Could you write a test case?  That'd prevent a regression here
going unnoticed.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]