This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing'


On 04/15/2013 02:36 PM, Siva Chandra wrote:

> ChangeLog
> 2013-04-15  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         Add option to link testcases with Pthreads library when
>         using 'prepare_for_testing' in tests.

Super nit, but do we need "with_" ?  We don't say "with_debug" or
"with_nowarnings" either.  I'd suggest just "pthread".  Singular, as
GNU uses -pthread / -lpthread.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]