This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC, testsuite] Remove semicolon after 'return'


On 03/14/2013 01:47 AM, Yao Qi wrote:
> Hi,
> During the review of CTF patches, Tom pointed out the semicolon after
> "return" is not necessary.  

Not just return, but pretty much after any command.  ';' is
the command separator, and you don't need it if there's no
other command on the same line afterwards.

> Since people usually copy-paste test
> cases, the code semicolon-after-return will be easily propagated in
> the testsuite.  This patch remove all the semicolons after return.

Thanks, this is great.

> 
> Tested on x86_64-linux native and gdbserver.  Is it OK?

Looks good to me.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]