This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix for PR c++/15203 and PR c++/15210
- From: Tom Tromey <tromey at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Keith Seitz <keiths at redhat dot com>
- Date: Wed, 13 Mar 2013 14:16:21 -0600
- Subject: Re: [PATCH] Fix for PR c++/15203 and PR c++/15210
- References: <m3a9qdnmti.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> And then, printing the value of `var':
Sergio> (gdb) print 'foo::bar()::var'
Sergio> GDB would fall in an internal_error:
Sergio> This may not be the ideal solution, according to Keith it would
Sergio> be good to implement productions on c-exp.y in order to
Sergio> recognize CLASS::FUNCTION::VARIABLE, but it is a solution which
Sergio> works with what we have today.
I'm not sure about this idea. Extensions make me a bit nervous, I
suppose.
Sergio> + else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK | BSF_GNU_UNIQUE))
I think this line is too long.
Sergio> +# Regression test for PR c++/15203 and PR c++/15210
Sergio> +gdb_test "print 'gnu_obj_1::method()::sintvar'" "\\$\[0-9\]+ = 4" \
Sergio> + "simple object, static const int, accessing via 'class::method::variable"
I think the second line should only be indented 4 spaces.
Ok with those changes.
Tom