This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 12/15] Write tracepoint definition in CTF and read.

From: Tom Tromey <tromey at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Tue, 12 Mar 2013 14:02:46 -0600
Subject: Re: [PATCH v3 12/15] Write tracepoint definition in CTF and read.
References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-13-git-send-email-yao@codesourcery.com>

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-03-08  Yao Qi  <yao@codesourcery.com>
Yao> 	* ctf.c (CTF_EVENT_ID_TP_DEF): New macro.
Yao> 	ctf_write_header): Define event type "tp_def" in metadata.
Yao> 	(ctf_write_uploaded_tp): Write tracepoint definition to CTF.
Yao> 	(SET_ARRAY_FIELD, SET_STRING_FIELD): New macros.
Yao> 	(ctf_read_tp): New.
Yao> 	(ctf_open): Call ctf_read_tp.  Adjust the event id checking.
Yao> 	Call merge_uploaded_tracepoints.

This looks good to me, with one tiny nit:

Yao> +   is about all aspects of a uploaded tracepoint.  Note that the

"an uploaded".

Tom

References:
- [PATCH v3 00/15] CTF Support
  - From: Yao Qi
- [PATCH v3 12/15] Write tracepoint definition in CTF and read.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]