This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] "constify" parse_exp_1


On 03/12/2013 03:18 AM, Pedro Alves wrote:
s/craete/create

Fixed.


(Minor note: pedantically, uppercase is used when talking
about the value of the variable, rather than the variable
itself.)

Fixed/changed.


-extern char *skip_to_space (char *inp);
+#define skip_to_space(INP) ((char *) skip_to_space_const ((INP)))

Double (())s not necessary:

Fixed.



#define skip_to_space(INP) ((char *) skip_to_space_const (INP))


Can you please add:

+ /* A const-correct version of the above. */


Fixed.


Otherwise this all looks good to me.


Committed. Thank you for taking a look at this.


Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]