This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/5] Check TSV value from the remote target and trace file.


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-03-07  Yao Qi  <yao@codesourcery.com>
Yao> 	* gdb.trace/tsv.exp (check_tsv): New.
Yao> 	(top level): Save a tfile on current trace session. Call
Yao> 	check_tsv on live target.  Load the tfile with target tfile
Yao> 	and call check_tsv again.

Yao> +# Save trace frames to tfile.
Yao> +gdb_test "tsave ${testfile}.tf" \
Yao> +    "Trace data saved to file '${testfile}.tf'.*"

Would you mind using standard_output_file to name the .tf file?
That would help my eventual test suite patches.

Yao> +proc check_tsv { data_source } { with_test_prefix "${data_source}" {

I know we have this formatting elsewhere, but it is not really correct.
Put the with_test_prefix on a new line, reindent the body, and...

Yao> +    gdb_test "tfind 0"
Yao> +    gdb_test "print \$tvar5" " = 16" \
Yao> +	"Print a trace state variable"
Yao> +    gdb_test "tfind" "Target failed to find requested trace frame.*"
Yao> +}}

... split the "}}".

Ok with these changes.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]