This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Yao, Sorry, I had already applied the patch before I saw your email.
Minor suggestion, if they can fit in one line, better to write them in one line. The first backslash is not necessary. Here and somewhere else. We can write them in two lines:I will keep this in mind for future work.
gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \ "set trace buffer size 1"
Document trace-buffer-size set and show commands.
The indentation looks odd here.
+ set_trace_buffer_size, NULL, + &setlist, &showlist); +
Indentation looks odd to me.
Thanks, Abid
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |