This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch v9 08/23] gdbserver, linux, btrace: add btrace support for linux-low

On Mon, 04 Mar 2013 18:05:55 +0100, Markus Metzger wrote:
> +  if (tinfo != NULL)
> +    tinfo->ptr_bits = register_size (0) * 8;

The diff against Pedro's review is OK; except for the Pedro's complaint on
PTR_BITS; but I see it is an abstraction as it is used in gdb/common/ while in
gdb/ one needs to use gdbarch_ptr_bit (gdbarch) and in gdbserver/ one needs to
use register_size (0).

There could be some more general abstraction put in gdb/common/ but I find it
acceptable as is for this patch.


Thanks,
Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]