This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] Save trace into CTF format
On 02/28/2013 11:31 AM, Andreas Schwab wrote:
> Yao Qi <yao@codesourcery.com> writes:
>
>> On 02/27/2013 10:17 AM, Yao Qi wrote:
>>> +static void
>>> +ctf_write_frame_v_block (struct trace_file_writer *self,
>>> + int num, LONGEST val)
>>> +{
>>> + struct ctf_writer_data *data = self->data;
>>> + int one = 1;
>>> +
>>> + /* Event Id. */
>>> + ctf_save_align_write (&data->tcs, (void *) &one, 4, 4);
>>
>> "&one" should be cast to "gdb_byte *" instead of "void *".
>
> Either one should be int32_t, or 4 should be sizeof (one).
And what about endianness?
--
Pedro Alves