This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix a bug in cmd_qtbuffer.

On 02/26/2013 07:23 PM, Pedro Alves wrote:
On 02/25/2013 03:11 AM, Yao Qi wrote: 
Hi,
When playing with packet "qTBuffer", I find a bug in cmd_qtbuffer.  We
don't have to set '\0' to OWN_BUF, because convert_int_to_ascii did
that.  On the other hand, it is incorrect to set '\0' to own_buf[num]
because convert_int_to_ascii writes 2 * num of bytes to OWN_BUF, it
is correct to set '\0' to own_buf[2 * num].  This patch fixes the bug
I found when using "qTBuffer".

Regression tested on x86_64-linux. OK?

OK, thanks.


Thanks for the review. Committed.

--
Yao (éå)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]