This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Simulator for 64-bit CPU now writes correct gmon.out files


On Saturday 09 February 2013 11:40:35 Holger Teutsch wrote:
> GDB's simulator as of 7.5.1 did not write out correct "gmon.out" files
> for 64-bit CPUs.
> 
> The attached patch adds this functionality.

your patch changes it so it uses the old BSD style header for 32bit targets 
but the new BSD4.4 style header for 64bit targets (going by gprof/gmon.h).  
there's no reason to diverge like that.  i would keep them both with the old 
style (since it's much simpler).

if you really wanted to update things, i would say convert it to use gmon 
style output.  if you wanted super extra brownie points, the sim-profile.c and 
gmon_io.c code really should be unified :).
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]