This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] Get trace file name when using 'target tfile'
- From: Eli Zaretskii <eliz at gnu dot org>
- To: "Abid, Hafiz" <hafiz_abid at mentor dot com>
- Cc: palves at redhat dot com, yao at codesourcery dot com, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Fri, 15 Feb 2013 00:02:13 +0200
- Subject: Re: [Patch] Get trace file name when using 'target tfile'
- References: <1360856970.2842.4@abidh-ubunto1104>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 14 Feb 2013 15:49:30 +0000
> From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> CC: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>,
> <marc.khouzam@ericsson.com>
>
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or
> non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
>
> How does it look?
OK, but:
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -150,6 +150,9 @@ show filename-display
> ** The response to breakpoint commands and breakpoint async records
> includes an "installed" field containing a boolean state about each
> non-pending tracepoint location is whether installed on target or not.
> + ** Output of the "-trace-status" command includes a "trace-file" field
> + containing the name of the trace file being examined. This field is
^^
Two spaces between sentences, please.
The documentation parts are OK with that change. Thanks.