This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
On 02/14/2013 06:24 PM, Tom Tromey wrote:
> Pedro> Yeah... It'd be an easier sell if libiberty wasn't such a
> Pedro> kitchen sink. I know that parts of libiberty would be problematic
> Pedro> for the Windows CE (I know, it's rotten by now), not sure about
> Pedro> other ports.
>
> I suppose my main concern here is that the gdb/gdbserver unification
> project will end up needing to reimplement chunks of libiberty.
> But that would be a bad result, since libiberty already exists.
Understood and agreed. I just prefer to cross that bridge when we
come to it. BTW, I think with ACX_CONFIGURE_DIR, the fact that libiberty
is at the top level and gdbserver isn't is no longer a problem. That's
what we use to configure the gnulib/ dir under gdbserver.
> I don't really care so much about this particular function.
> It is small, it doesn't really matter. The xstrndup name is better
> (IMO), but unimportantly so.
--
Pedro Alves