This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 14 Feb 2013 12:53:38 +0000
Subject: Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp
References: <20130213203131.30816.4686.stgit@brno.lan> <87a9r8kk4r.fsf@fleche.redhat.com>

On 02/13/2013 08:56 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> This patch fixes it.  The issue is that we're entering the VALUE_LVAL
> Pedro> (x) == lval_memory branch by mistake for references.  The fix is just
> Pedro> to swap the tests so references are checked first, like value_addr
> Pedro> also handles references first.
> 
> Pedro> Comments?
> 
> It looks reasonable to me.

Thanks.  Checked in (v2).

-- 
Pedro Alves

References:
- [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp
  - From: Pedro Alves
- Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]