Re: [RFC/TileGX 5/6]show registers in columns

[Jiong Wang <jiwang at tilera dot com>]

Hi all,

  thanks for all these comments, happy Chinese lunar new year!

> > > +		  fprintf_filtered (file, "%02x", (unsigned char) buffer[idx]);
> > 	I do not think that this is the right way of printing the register
> > value, by doing all the work yourself. I am not completely sure
> > what the best solution would be, though. The other Global Maintainers
> > may have a more definitive answer, but perhaps plongest (value_as_long
> > (register_value)). My suggestion is a little iffy because it assumes
> > for instance that all register values are signed / or unsigned.
> Usually you'd use val_print.

   the reason why we do not use val_print is because, for a zero value, 
for x86, the default output is:

rax            0x7ffff7bd5f60  140737349771104
rbx            0x0     0
rcx            0x0      0

while I think it's better that the output is padded with zero which is 
MIPS's approach, for example:

rax            0x00007FFFF7BD5F60
rbx            0x000000000000000
rcx            0x000000000000000

> How about just exporting and
> calling default_print_one_register_info?  You get consistency
> with other archs for free, and unavailable values handled too.

good, I find some code is factored out as 
"default_print_one_register_info" since Aug, 2012,
but it always print a '\n' for each register , so it can not used for 
multi column output.

and this function print register value in both hex format and natural 
format, it consumes extra
width that there is no enough space left for multi columns.

all these are quite subjective,  I think this patch do not affect the 
correctness of tilegx gdb, so I do not
insist on it.

thanks.

---
Regards,
Jiong