This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: fix PR symtab/11464

Jan> That's true, that crashes even for me.  I still expected it crashes
Jan> for you if you remove the two lines:
Jan>          if (classification == NAME)
Jan>            break;
Jan> which cannot / does not crash.

I thought you were reporting that the test case did not crash before the
fix.

Now I don't understand what you are saying here.

>> I guess you are saying I should invert the if.
>> Ok, I will do that.

Jan> No, I did not mean that.  In fact I do not understand much what condition
Jan> inversion do you mean.

I mean now the patch reads:

	  if (classification != NAME)
	    context_type = yylval.tsym.type;

This still fixes the failing test case, but I haven't run it through a
complete regression test yet.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]