This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdbserver aarch64 fix the clamping of HW break point and watchpoint counts.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 07 Feb 2013 16:14:28 +0000
- Subject: Re: [PATCH] gdbserver aarch64 fix the clamping of HW break point and watchpoint counts.
- References: <5113CD7D.6080502@arm.com>
On 02/07/2013 03:51 PM, Marcus Shawcroft wrote:
> This issue came to light in the recent review of aarch64-linux-nat, and also needs resolving in GDBserver.
>
> OK?
OK.
>
> /Marcus
>
> 2013-02-07 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> * linux-aarch64-low.c (aarch64_arch_setup): Fix clamping of
> aarch64_num_wp_regs and aarch64_num_bp_regs.
Minor, minor nit: "Fix" is a "why" (which in general may end up wrong in
retrospect), while change log entries record the "what". This would
be more in accordance:
* linux-aarch64-low.c (aarch64_arch_setup): Clamp
aarch64_num_wp_regs and aarch64_num_bp_regs to
AARCH64_HWP_MAX_NUM and AARCH64_HBP_MAX_NUM respectively.
Sorry for being pedant.
--
Pedro Alves