This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble


On Wed, Feb 6, 2013 at 11:58 AM, Tom Tromey <tromey@redhat.com> wrote:
> Why is it a method on gdb.Architecture and not elsewhere?
> For example, we have gdb.Inferior.read_memory.

Based on a comment in this thread,
http://sourceware.org/ml/gdb-patches/2012-11/msg00052.html, I gather
that architecture could change between frames. Hence, would it not be
more appropriate to have this method on gdb.Architecture?

> Siva> +struct ui_out *py_out;
>
> I'd rather avoid new globals, and I don't see what this one adds.

The only reason I made it global is because there is no way currently
to free up a ui_out object from outside of ui-out.c. Do you think it
is OK to add a field ui_out_destroy_ftype to struct ui_out_impl? If
yes, then I think we can first add the support for this 'virtual
destructor' in a separate patch.

Thanks,
Siva Chandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]