Re: [patch] cleanup: remove unused - ada

[Aleksandar Ristovski <aristovski at qnx dot com>]

On 13-01-30 10:13 PM, Joel Brobecker wrote:
> [moving to gdb-patches]
>
> Hi Aleksandar,
>
> > This is removing unused variables and allows compiling with -Wunused.
> >
> > Thanks,
> >
> > Aleksandar Ristovski
> > QNX Software Systems
> >
> >
> > ChangeLog:
> >
> >   Aleksandar Ristovski  <aristovski@qnx.com>
> >
> >          * ada-lang.c (assign_aggregate): Remove unused IS_ARRAY_AGGREGATE.
> >          * ada-valprint.c (ada_print_floating): Remove unused LEN.
>
> Indeed, these variables look unused. The patch is approved, and since
> each change is independent of the other, if you could commit those
> separately, I'd appreciate it.
>
> One minor thing with the ChangeLog: The capitalized variable name
> means "the value of the variable [whose name is capitalized]".
> I'd probably say: Remove unused variable "is_array_aggregate".
>
> Thanks for catching this.


Thank you,

This is now committed in two commits as requested:

http://sourceware.org/ml/gdb-cvs/2013-02/msg00006.html
and
http://sourceware.org/ml/gdb-cvs/2013-02/msg00007.html

(I somehow managed to put it at the end of the cue even though your 
reply came first... Sorry about that).

Thanks,

Aleksandar Ristovski
QNX Software Systems