This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64-newlib-tdep patch
- From: Pedro Alves <palves at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 01 Feb 2013 19:11:40 +0000
- Subject: Re: [PATCH] aarch64-newlib-tdep patch
- References: <50FED481.5060103@arm.com>
On 01/22/2013 06:03 PM, Marcus Shawcroft wrote:
> Pedro also commented that we need to update the documentation w.r.t the AArch64 port. There will be a separate patch for documentation shortly...
Thanks for that. Note you'll also need a NEWS entry
mentioning the new port.
> 2013-01-22 Jim MacArthur <jim.macarthur@arm.com>
> Marcus Shawcroft <marcus.shawcroft@arm.com>
> Nigel Stephens <nigel.stephens@arm.com>
> Yufeng Zhang <yufeng.zhang@arm.com>
>
> * aarch64-newlib-tdep.c: New file.
> * configure.tgt: Add aarch64-newlib-tdep.o to gdb_target_obs of
> aarch64*-*-elf.
* configure.tgt (aarch64*-*-elf): Add aarch64-newlib-tdep.o to
gdb_target_obs.
> * defs.h (enum gdb_osabi): Add GDB_OSABI_NEWLIB.
> * Makefile.in (ALL_64_TARGET_OBS): Add aarch64-newlib-tdep.o.
> (ALLDEPFILES): Add aarch64-newlib-tdep.c.
> * osabi.c (gdb_osabi_names): Add "Newlib".
This is OK. A sniffer would indeed by nice... Something like
looking for impure_ptr or some such internal newlib symbol would
probably be all one can do, I think. But we'll want to make
sure that cases like Cygwin, which use Newlib, don't end up
selecting GDB_OSABI_NEWLIB.
--
Pedro Alves