This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename

From: Tom Tromey <tromey at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 25 Jan 2013 07:28:16 -0700
Subject: Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
References: <20130117222242.GG16249@host2.jankratochvil.net> <87ip6q1gbo.fsf@fleche.redhat.com> <20130124215609.GA31688@host2.jankratochvil.net>

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> This spot still uses symtab->filename directly.
Tom> Is that intentional?  If so I think it should perhaps have a comment.

Jan> Yes.
Jan> +         /* Check first sole SYMTAB->FILENAME.  It does not need to be
Jan> +            a substring of symtab_to_fullname as it may contain "./" etc.  */

Sorry, missed that.

Tom> This spot uses filename_cmp with symtab_to_filename.
Tom> Is that intentional?
Tom> It seems a bit strange to me to allow the filename-display setting to
Tom> control comparisons.

Jan> Because this is a maintenance command.

Ok, I see.  I'm satisfied.

Tom

Follow-Ups:
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Jan Kratochvil

References:
- [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Jan Kratochvil
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Tom Tromey
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]