This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] x86, perf, bts: disable BTS from Nehalem to Ivy Bridge
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Ingo Molnar <mingo at kernel dot org>
- Cc: "mingo at redhat dot com" <mingo at redhat dot com>, "mingo at elte dot hu" <mingo at elte dot hu>, "linux-kernel at vger dot kernel dot org" <linux-kernel at vger dot kernel dot org>, Mark Kettenis <kettenis at gnu dot org>, Pedro Alves <palves at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 24 Jan 2013 16:17:26 +0000
- Subject: RE: [PATCH] x86, perf, bts: disable BTS from Nehalem to Ivy Bridge
- References: <1354876511-25294-1-git-send-email-markus.t.metzger@intel.com> <20130124154637.GB32146@gmail.com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Ingo Molnar
> Sent: Thursday, January 24, 2013 4:47 PM
> > Starting with Nehalem, the BTS "from" information may in some cases be
> > incorrect (AAJ122).
> >
> > This has been detected while adding branch tracing support to gdb, where it
> > results in sporadic test fails.
> >
> > Disable BTS support on Nehalem, Westmere, Sandy Bridge, and Ivy Bridge.
>
> But the failures are rare, so the BTS data is still correct
> statistically, by and large, right? So why not just keep it
> as-is and teach tooling to be more robust about implausible
> trace entries? It has to be ready for that eventuality *anyway*.
Yes, the fails are rare. They are frequent enough, however, to cause sporadic test fails.
The problem is that you can't reliably detect such fails. In the worst case, GDB would show wrong but plausible trace. Typically, GDB just shows garbage (i.e. impossible trace) in such cases.
I'm afraid one might endlessly debate whether the feature as-is is useful or not. It is working fine on Atom so I chose to disable it on core.
The GDB folks would rather not disable the feature inside GDB; they prefer that it is disabled in the kernel. There will be an additional check inside GDB to support older kernel versions.
Regards,
markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052