This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't check PST is NULL in read_symtab


On 01/11/2013 10:34 PM, Tom Tromey wrote:
Joel> If PST must not be NULL, I think that it should be documented in
Joel> psympriv.h. I am also wondering whether an assertion would be
Joel> useful or not; maybe not, just thinking out loud.

Joel> Tom and Doug are more involved in this area, so they'll probably
Joel> have a more definitive answer.

An assert would be fine by me.

An assert that PST is not NULL at the beginning of these functions dbx_psymtab_to_symtab_1, dwarf2_psymtab_to_symtab, mdebug_psymtab_to_symtab, and xcoff_psymtab_to_symtab_1?


--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]