This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RFC: completion for "set cp-abi"
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 08 Jan 2013 09:42:15 -0700
- Subject: RFC: completion for "set cp-abi"
This patch adds a completion function for "set cp-abi".
Built and regtested on x86-64 Fedora 16.
New test case included.
Tom
* cp-abi.c (cp_abi_completer): New function.
(_initialize_cp_abi): Set completer for "set cp-abi".
* gdb.base/completion.exp: Add "set cp-abi" completion test.
---
gdb/cp-abi.c | 28 ++++++++++++++++++++++++++--
gdb/testsuite/gdb.base/completion.exp | 3 +++
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/gdb/cp-abi.c b/gdb/cp-abi.c
index 37cf9c9..39da11a 100644
--- a/gdb/cp-abi.c
+++ b/gdb/cp-abi.c
@@ -314,6 +314,27 @@ set_cp_abi_cmd (char *args, int from_tty)
error (_("Could not find \"%s\" in ABI list"), args);
}
+/* A completion function for "set cp-abi". */
+
+static VEC (char_ptr) *
+cp_abi_completer (struct cmd_list_element *ignore,
+ char *text, char *word)
+{
+ static const char **cp_abi_names;
+
+ if (cp_abi_names == NULL)
+ {
+ int i;
+
+ cp_abi_names = XNEWVEC (const char *, num_cp_abis + 1);
+ for (i = 0; i < num_cp_abis; ++i)
+ cp_abi_names[i] = cp_abis[i]->shortname;
+ cp_abis[i] = NULL;
+ }
+
+ return complete_on_enum (cp_abi_names, text, word);
+}
+
/* Show the currently selected C++ ABI. */
static void
@@ -334,13 +355,16 @@ extern initialize_file_ftype _initialize_cp_abi; /* -Wmissing-prototypes */
void
_initialize_cp_abi (void)
{
+ struct cmd_list_element *c;
+
register_cp_abi (&auto_cp_abi);
switch_to_cp_abi ("auto");
- add_cmd ("cp-abi", class_obscure, set_cp_abi_cmd, _("\
+ c = add_cmd ("cp-abi", class_obscure, set_cp_abi_cmd, _("\
Set the ABI used for inspecting C++ objects.\n\
\"set cp-abi\" with no arguments will list the available ABIs."),
- &setlist);
+ &setlist);
+ set_cmd_completer (c, cp_abi_completer);
add_cmd ("cp-abi", class_obscure, show_cp_abi_cmd,
_("Show the ABI used for inspecting C++ objects."),
diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp
index 566f5e0..2492226 100644
--- a/gdb/testsuite/gdb.base/completion.exp
+++ b/gdb/testsuite/gdb.base/completion.exp
@@ -707,6 +707,9 @@ gdb_test "complete ptype struct some_" "ptype struct some_struct"
gdb_test "complete ptype enum some_" "ptype enum some_enum"
gdb_test "complete ptype union some_" "ptype union some_union"
+
+gdb_test "complete set cp-abi aut" "set cp-abi auto"
+
# Restore globals modified in this test...
set timeout $oldtimeout1
--
1.7.7.6