This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add extern of output_command to utils.h


On Fri, Jan 4, 2013 at 5:41 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui>    * tracepoint.c: Remove extern of function output_command.
> Hui>    * utils.h (output_command): New extern.
>
> I appreciate you doing this, but utils.h seems like a weird place to put
> this.
>
> I don't know of a better place but I suppose if I were doing it, I would
> look for a header that, ideally, is both printing-related and already
> has some _command declarations in it.
>
> Tom

Hi Tom,

What about add this extern to valprint.h that is included by printcmd.c?

Thanks,
Hui


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]