Re: [patch v6 12/12] btrace, x86: disable on some processors

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Mon, 17 Dec 2012 17:01:41 +0100, markus.t.metzger@intel.com wrote:
> --- a/gdb/common/linux-btrace.c
> +++ b/gdb/common/linux-btrace.c
> @@ -247,7 +247,50 @@ perf_event_read_bts (struct btrace_target_info* tinfo, const uint8_t *begin,
>  int
>  linux_supports_btrace (void)
>  {
> +#if defined(__i386__) || defined(__x86_64__)
> +  {
[...]
> +
> +#else /* defined(__i386__) || defined(__x86_64__) */

BTW defined (__i386__) or defined __i386__ .

http://www.gnu.org/prep/standards/standards.html#Comments

Therefore:
#if defined __i386__ || defined __x86_64__

but then negative:

#else /* !defined __i386__ && !defined __x86_64__ */
#endif /* !defined __i386__ && !defined __x86_64__ */

(+cpuid comments in other mails)

> +
> +  return 0;
> +
> +#endif /* defined(__i386__) || defined(__x86_64__) */
>  }
>  
>  /* See linux-btrace.h.  */
> -- 
> 1.7.6.5


Thanks,
Jan