This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [2/2] RFC: build machoread.c in more cases
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 13 Dec 2012 20:02:59 +0000
- Subject: Re: [2/2] RFC: build machoread.c in more cases
- References: <87fw394tl1.fsf@fleche.redhat.com>
On 12/13/2012 07:53 PM, Tom Tromey wrote:
> I noticed that machoread.c is only built for Darwin.
>
> This seems wrong to me. It seems like it should instead be built
> whenever the needed BFD code is built. This is what we do for
> elfread.c.
>
> This patch has two benefits. First, it means building with a Darwin
> target is more possible. Second, it means that --enable-targets=all
> will build machoread.c, leading to fewer chances for build regressions
> there. The is the case I ran into...
>
> Comments?
Looks fine to me.
--
Pedro Alves