This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2

On 29/11/12 15:35, Tom Tromey wrote:
Marcus> +#include <inttypes.h>

Tom> Is this strictly necessary?

Marcus> The port uses the output specifier PRIx64 and friends in various
Marcus> places hence the inclusion of inttypes.h.  There are a number of
Marcus> places in the existing gdb and gdbserver code base where such marcros
Marcus> are already used.

I don't see any other places in gdb itself.

OK, The instance I noticed was in common:

./common/buffer.c:152: sprintf (str, "%" PRIx64,

.. but I see no reason not to switch to CORE_ADDR and core_addr_to_string_nz() for each of these PRIx64. I'll make this change in the next spin of the patches.

/Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]