This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: remove partial_symtab::objfile
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 28 Nov 2012 22:23:17 +0000
- Subject: Re: RFC: remove partial_symtab::objfile
- References: <87fw3t8k01.fsf@fleche.redhat.com>
On 11/28/2012 10:01 PM, Tom Tromey wrote:
> I'm curious what people think of this patch.
>
> This is another old patch that was sitting on one of my branches for
> trying to split 'struct objfile'. However, I realized this patch is
> independent and pretty simple and so could go in separately.
>
> The basic idea is that partial_symtab doesn't really need a back-pointer
> to the objfile. In all places that this might be used, the information
> is already readily available, either directly or in some cases in the
> caller.
>
> This is a necessary step for symbol table location independence; but I
> see it as a general cleanup as well -- back-pointers are better avoided
> when possible, and it saves some tiny amount of memory.
You can probably guess that I agree with this, but FAOD:
+1.
--
Pedro Alves