This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix libtool.m4 dlopen lookup for mingw


> Looks like libtool.m4 is the right place to do such sort of checks.
> What do you think?

I cannot really answer that question authoratively, because the file
is maintained by GCC, as far as I can tell. In my opinion, and if I had
to write this check today, I'd probably do it differently, yes. For
instance, I would do all the dlopen tests, and if those fails, then
I would test for LoadLibrary as an alternative, etc. More generally
speaking, the recommended way of writing checks is to check for
features, rather than setting things up based on the type of system.
That being said, the current implementation kind of works, and enhancing
libtool.m4 might not be sufficient. I am not sure.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]