This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] use gdbarch_addr_bits_remove for entry point address


On 11/26/2012 07:57 PM, Pedro Alves wrote:
Please be more specific:

  	* objfiles.c (entry_point_address_query): Call
	gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove
	here ...
  	(init_entry_point_info): ... instead of here.

That's more useful for archaeology.

> * solib-svr4.c (exec_entry_point): Likewise.
"Likewise" here doesn't make sense. Perhaps:

* solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove.


The changelog entry is updated, and patch is committed. Thanks for the review.


--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]