This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/4] Misc annotations changes.


On 11/21/2012 03:42 PM, Pedro Alves wrote:
> The reason I'm looking at annotation code is that I made a change
> that puts software single-step breakpoints in the regular breakpoint
> chain, and then that triggers breakpoints-invalid annotations for
> each sss breakpoint that didn't happen before, and in turn that
> leads to the gdb.log getting filled up with useless notifications
> and the tests timing out.  I had a small patch to handle this, but it turns
> out incomplete.  Further looking at this issue, I've decided to go ahead
> and fully convert the breakpoints-invalid annotation to observers.

And there are the changes.  The changes are sort of independent, but
the each builds on the previous.  This order was chosen to avoid
introducing failures in the tree at each stage.

I've tested this on X86_64 Fedora 17, and smoke tested it with emacs
24.1.1 in gud-gdb mode.

Let me know if you see an issue with this.

---

Pedro Alves (4):
      Remove (alledged) "breakpoints-changed" annotation suppression on ignore count changes.
      Suppress repeated annotations until GDB is ready to accept input.
      Fully move the breakpoints-invalid annotation to observers.
      Skip breakpoints-invalid annotations for internal|momentary breakpoints.


 gdb/annotate.c                     |   61 ++++++++++++++++++------------------
 gdb/annotate.h                     |    5 +--
 gdb/breakpoint.c                   |   11 +-----
 gdb/event-top.c                    |    3 ++
 gdb/testsuite/gdb.base/annota1.exp |   22 ++++++++-----
 gdb/testsuite/gdb.cp/annota2.exp   |   13 +++++---
 6 files changed, 57 insertions(+), 58 deletions(-)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]